Skip to content

Refactor activation_quantizer_factory_mapping out of FrameworkInfo#1484

Merged
elad-c merged 3 commits intomainfrom
refactor_activation_quantizer_factory_mapping
Jul 1, 2025
Merged

Refactor activation_quantizer_factory_mapping out of FrameworkInfo#1484
elad-c merged 3 commits intomainfrom
refactor_activation_quantizer_factory_mapping

Conversation

@elad-c
Copy link
Copy Markdown
Contributor

@elad-c elad-c commented Jul 1, 2025

Pull Request Description:

Rename core.pytorch\keras.quantizer to quantization.
Move activation_quantizer_factory_mapping from frameworkInfo to framework core code.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Move activation_quantizer_factory_mapping from frameworkInfo to framework core code.
@lior-dikstein
Copy link
Copy Markdown
Contributor

Why use get_activation_quantization_fn_factory instead of get_activation_quantization_fn? Why not simply call get_activation_quantization_fn directly?

@elad-c elad-c merged commit 3644002 into main Jul 1, 2025
31 checks passed
@elad-c elad-c deleted the refactor_activation_quantizer_factory_mapping branch July 1, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants